Mock time.sleep in unit tests #307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iquintero
approved these changes
Jul 19, 2018
Codecov Report
@@ Coverage Diff @@
## master #307 +/- ##
==========================================
+ Coverage 92.75% 92.92% +0.17%
==========================================
Files 50 50
Lines 3463 3463
==========================================
+ Hits 3212 3218 +6
+ Misses 251 245 -6
Continue to review full report at Codecov.
|
|
Just a comment. If time.sleep is mocked, the test coverage for tensorboard will be dropped a lot since the mock test will be finished very soon before tensorboard process actually starts (initialization takes some time). But we may not need full coverage for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This change speeds up our unit tests.
Current test-run duration:
real 0m49.736s
user 0m6.219s
sys 0m1.089s
With this change:
real 0m9.447s
user 0m6.856s
sys 0m1.115s
Merge Checklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your pull request.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.